Skip to content

Rudimentary table support #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Rudimentary table support #39

wants to merge 4 commits into from

Conversation

@romanofski
Copy link

@romanofski romanofski commented Mar 22, 2016

Please don't merge this patch yet since I do have a few questions:

  • I couldn't figure out how to apply a certain styling for the table header. I've commented out the code and added a TODO. Any ideas?
  • I've checked the mistune docs in regards to different supported layouts but haven't tested them yet. Not sure how much we'd like to support.
  • Couldn't make links to appear in the table cells, since the lpod-python API seems to not support it. If there are any pointers in case you've tried it, please let me know.
    At this point the implementation does all what I need. Let me know what you think.

Commit message:
Add basic support for tables. The conversion discards any styling information given by markdown. It renders the table with a fixed style.
This fix is related to #26

Ceaveats:

  • one table per slide
  • no header styling
  • no support for links in table cells

Roman Joost added 4 commits March 22, 2016 15:39
Rudimentary table support
27b4415 
Add basic support for tables. The conversion discards any styling
information given by markdown. It renders the table with a fixed style.
This fix is related to thorstenb#26

Ceaveats:

  * one table per slide
  * no header styling
  * no support for links in table cells
Fixes PEP8 error introduced by previous patch
088fb4d
Treat table values as text content only
388bcbe 
Presentations might contain links and other markup content. This patch
does not use the table API, but rather assumes that cell content is text
only.
Insert complete cell content
deb0324 
Grabbing only the first parsed cell content discards information. This
patch changes the former behaviour to use the complete parsed markup
content for the table cell.
@thorstenb
Copy link
Owner

thorstenb commented Mar 31, 2016

Wow - nice stuff! Re-surfacing from serious work swampage, will look & play with it shortly.

@romanofski
Copy link
Author

romanofski commented Mar 31, 2016

Dear @thorstenb thank you very much. My last point I had raised (couldn't make links to appear) is solved by my last commit. It comes at a cost of loosing any information for values and value types as you might need for spread sheets. I thought for a presentation that use case doesn't really exist.

I'm still not sure about the styling for the table. I was hoping I could define that in a master of the presentation, but my PowerPoint/OpenOffice skillz are limited in that matter.

Looking forward to your feedback.

@koppor
Copy link
Contributor

koppor commented Apr 13, 2017

I would like to see table support. Any news on this? 😇

@thorstenb
Copy link
Owner

thorstenb commented Mar 4, 2025

Hi @romanofski in case you're still around - we've finally managed to migrate odpdown to python3, so I'm suddenly quite motivated hacking it again - any chance you could rebase / update your PR here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romanofski @thorstenb @koppor